RFR 8166358: Re-enable String verification in java_lang_String::create_from_str()

[coleen.phillimore at oracle.com]

On 5/22/20 10:51 AM, coleen.phillimore at oracle.com wrote:
>
>
> On 5/22/20 9:43 AM, Harold Seigel wrote:
>> Hi Coleen,
>>
>> Could you rename SystemDictionary::valid_class_name() to something 
>> else, say valid_class_name_length()?  It's current name implies that 
>> it is doing a full syntactic check of the class name.
>
> Yes, I agree that it confuses it with 
> ClassFileParser::verify_legal_class_name.   How about 
> SystemDictionary::make_class_name_symbol() ?

Or just SystemDictionary::class_name_symbol(char* name, exception, 
TRAPS) which does conversion from char* to Symbol with some checks.

Coleen
> Thanks,
> Coleen
>
>>
>> Thanks, Harold
>>
>> On 5/21/2020 4:34 PM, coleen.phillimore at oracle.com wrote:
>>> Summary: Check for invalid strings in class names in debug mode, and 
>>> only verify valid strings in create_for_str().
>>>
>>> See bug for more information on why this commented out code needs to 
>>> be conditional but not commented out.  Tested with mach5 tier1-6, 
>>> and new test for new -Xcheck:jni check.
>>>
>>> open webrev at 
>>> http://cr.openjdk.java.net/~coleenp/2020/8166358.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8166358
>>>
>>> Thanks,
>>> Coleen
>