RFR(XS): 8246109: Remove unneeded undef CS

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri May 29 00:18:33 UTC 2020


On 5/28/20 8:10 PM, Mikael Vidstedt wrote:
> Please review this small change which removes a now unneeded #undef:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8246109
> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8246109/webrev.00/open/webrev/

src/hotspot/share/prims/methodHandles.cpp
     No comments.

Thumbs up. This is a trivial fix and doesn't require you to wait for
24 hours...

Dan


>
>
> Background (from JBS):
>
> In src/hotspot/share/prims/methodHandles.cpp one can find the following code:
>
> #undef CS // Solaris builds complain
>
> I chose not to remove it as part of the Solaris/SPARC removal (JDK-8241787) the the fear of breaking some other platform and making the already-challenging work even harder.
>
> I have now verified that removing the line at least works for all the Oracle builds.
>
>
> Testing:
>
> tier1 + builds-tier{2..5}
>
> Cheers,
> Mikael
>



More information about the hotspot-runtime-dev mailing list