RFR: 8255756: Disabling logging does unnecessary work

Claes Redestad redestad at openjdk.java.net
Mon Nov 2 13:28:10 UTC 2020


When disabling UL outputs - for example when shutting down the JVM - we are doing some unnecessary work:

- we always disable all outputs in bulk, but the routine searches up outputs one by one in the LogTagSet output lists - instead we could just drop all nodes in these lists in one quick pass.
- when finalizing for a JVM shutdown, it's unnecessary to update decorators

While not technically startup this gets rid of some noise on JVM exit (~45k instructions) that show up when using full JVM executions as a proxy for startup testing (or when running many shortlived JVMs back-to-back).

-------------

Commit messages:
 - Improve wording
 - Remove extra lines
 - Clean up and fix clear
 - Shortcut clearing of all outputs from tagsets
 - Shortcut clearing of all outputs from tagsets
 - Fix loop
 - Merge branch 'master' into disable_logging
 - Disabling logging outputs on exit does unnecessary work

Changes: https://git.openjdk.java.net/jdk/pull/1005/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1005&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8255756
  Stats: 48 lines in 5 files changed: 30 ins; 4 del; 14 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1005.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1005/head:pull/1005

PR: https://git.openjdk.java.net/jdk/pull/1005


More information about the hotspot-runtime-dev mailing list