RFR: 8255716: AArch64: Regression: JVM crashes if manually offline a core

Patrick Zhang qpzhang at openjdk.java.net
Mon Nov 2 13:56:54 UTC 2020


On Mon, 2 Nov 2020 13:45:00 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Please review this change that removed the unnecessary check **cpu_lines == os::processor_count()** from VM_Version::get_os_cpu_info inside src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp. 
>> 
>> This **assertion** is practically not needed. While a test system with some cores intentionally turned off, e.g. via echo 0 > /sys/devices/system/cpu/cpu1/online, **java -version** would crash, building openjdk on this system would fail too. 
>> 
>> This regression issue was introduced by https://github.com/openjdk/jdk/commit/ec9bee68
>> 
>> Testing:
>> - java -version, building openjdk as smoke tests
>> - jtreg tier1 as sanity check
>
> Marked as reviewed by adinn (Reviewer).

Thanks for your review and comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/983


More information about the hotspot-runtime-dev mailing list