RFR: 8255744: Zero: handle JVM_CONSTANT_DynamicInError

Severin Gehwolf sgehwolf at openjdk.java.net
Tue Nov 3 10:24:04 UTC 2020


On Mon, 2 Nov 2020 11:44:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> JDK-8186211 introduced a few negative tests for Condy, and Zero seem to fail them:
> 
> $ CONF=linux-x86_64-zero-fastdebug make run-test TEST=java/lang/invoke/condy/CondyRepeatFailedResolution.java
> # Internal Error (/home/shade/trunks/jdk/src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp:2289), pid=574573, tid=581749
> # Error: ShouldNotReachHere()
> 
> After some debugging, I think Zero misses to handle `JVM_CONSTANT_DynamicInError`. I believe we can just do the same thing as `JVM_CONSTANT_Dynamic`, and then let `CALL_VM` to go to `handle_exception` on another resolution failure.
> 
> Additional testing:
>  - [x] `CondyRepeatFailedResolution` test now passes on Linux x86_64 Zero

Looks OK.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1004


More information about the hotspot-runtime-dev mailing list