RFR: 8255384: Remove special_runtime_exit_condition() check from SS::block() [v2]

[Richard Reingruber]

On Tue, 3 Nov 2020 17:19:04 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make direct calls instead of using transition wrappers
>
> Hi Patricio,
> 
> the change looks good to me.
> 
> In `JavaThread::check_and_handle_async_exceptions()` the block depending on is_at_poll_safepoint() looks like dead code now. I wonder if `ThreadSafepointState::_at_poll_safepoint` could even be DEBUG_ONLY?
> 
> Thanks, Richard.

> 
> > In `JavaThread::check_and_handle_async_exceptions()` the block depending on is_at_poll_safepoint() looks like dead code now. I wonder if `ThreadSafepointState::_at_poll_safepoint` could even be DEBUG_ONLY?
> 
> Yes, I actually thought about doing that in the first version but then I
> realized that code was already dead even before this change. We only
> call set_at_poll_safepoint() in handle_polling_page_exception() and the
> handle_special_runtime_exit_condition() call in SS::block() already
> excludes checking async exceptions for that case. The call I removed
> from ~TIVMFH was exactly the same. So I don't see a path where it could
> be called where is_at_poll_safepoint() returned true.
> I agree that _at_poll_safepoint should probably be DEBUG_ONLY. Then we
> should add an assert in check_and_handle_async_exceptions(). Do you
> think I should do that here or in another bug?

I'd think you can do it in another bug also. I'm ok either way actually.

Thanks, Richard.

-------------

PR: https://git.openjdk.java.net/jdk/pull/913