RFR: 8255784: appcds/javaldr/ExceptionDuringDumpAtObjectsInitPhase.java test failed resulting in VM crash

[Calvin Cheung]

On Tue, 3 Nov 2020 17:12:06 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Please review this simple change.
>   The crash is caused by vm_exit_during_initialization which calls vm_exit, the latter will go check vm shutdown procedures. The shutdown checks thread and lock state, finds inconsistent state so the check fails. Here we could just use vm_direct_exit with some message as the process terminated.  vm_direct_exit just calls os::exit which quits without generating a coredump.
> 
> Tests: tier1-4
> 
> Thanks
> Yumin

Looks good.

src/hotspot/share/memory/archiveUtils.cpp line 328:

> 326:     vm_direct_exit(-1,
> 327:       err_msg("Out of memory. Please run with a larger Java heap, current MaxHeapSize = "
> 328:               SIZE_FORMAT "M", MaxHeapSize/M));

I didn't know the format string could be broken up into 2 lines.

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1040