RFR: 8255384: Remove special_runtime_exit_condition() check from SS::block() [v4]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Thu Nov 5 21:20:20 UTC 2020


On Thu, 5 Nov 2020 20:20:25 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> Okay. It took me some time to be convinced of the equivalence,
> but I'm on-board at this point. The new code is much more clear
> and easy to reason about (once you convince yourself that the
> new, simpler code is equivalent to the older code).
> 
> As @dholmes-ora likes to say: the proof is in the testing. I'll add
> that the proof will be in the stress testing.
Sounds good. So far I tested it a lot in mach5 and locally and will run a last round before pushing.  : )

Thanks Dan!

> src/hotspot/share/runtime/safepoint.cpp line 952:
> 
>> 950:     // We never deliver an async exception at a polling point as the
>> 951:     // compiler may not have an exception handler for it. The polling
>> 952:     // code will notice the async and deoptimize and the exception will
> 
> Perhaps a little rewording:
> 
>     code will notice the pending async exception, deoptimize and the exception will
> 
> and then reformat the block comment a bit.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/913


More information about the hotspot-runtime-dev mailing list