RFR: 8255973: Add more logging to debug JDK-8255917 [v2]

[Yumin Qi]

On Wed, 11 Nov 2020 00:44:13 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix the region extra type name
>
> src/hotspot/share/services/virtualMemoryTracker.cpp line 396:
> 
>> 394:       if (reserved_rgn->flag() == mtJavaHeap) {
>> 395:         log_info(nmt)("CDS reserved region \'%s\' as a whole type heap " INTPTR_FORMAT ": " SIZE_FORMAT,
>> 396:                       reserved_rgn->flag_name(), p2i(reserved_rgn->base()), reserved_rgn->size());
> 
> Since you're logging the region name, I don't think you need to say `type heap`.

Thanks. fixed.

> src/hotspot/share/services/virtualMemoryTracker.cpp line 387:
> 
>> 385:       if (reserved_rgn->flag() == mtClassShared) {
>> 386:         log_info(nmt)("CDS reserved region \'%s\' as a whole type class (" INTPTR_FORMAT ", " SIZE_FORMAT ")",
>> 387:                       reserved_rgn->flag_name(), p2i(reserved_rgn->base()), reserved_rgn->size());
> 
> Since you're logging the region name, I don't think you need to say `type class`.

Fixed.

> src/hotspot/share/services/virtualMemoryTracker.hpp line 309:
> 
>> 307:   void  set_flag(MEMFLAGS flag);
>> 308:   inline MEMFLAGS flag() const            { return _flag;  }
>> 309:   // uncommitted thread stack bottom, above guard pages if there is any.
> 
> Line deleted by accident?

Yes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1150