RFR: 8255975: Fix AArch64 OpenJDK build failure with gcc-5

David Holmes dholmes at openjdk.java.net
Wed Nov 11 07:02:55 UTC 2020


On Fri, 6 Nov 2020 07:31:58 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:

> As one C++17 feature, the argument 'message' of static_assert can be optional.
> This feature, i.e. static_assert with no message, is supported by gcc-6 or
> higher.[1]
> 
> Add 'message' arguments in order to avoid compilation failures if gcc-5 is used.
> 
> [1] https://gcc.gnu.org/projects/cxx-status.html

This seems fine to me. This C++17 construct should not have crept in.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1088


More information about the hotspot-runtime-dev mailing list