RFR: 8255973: Add more logging to debug JDK-8255917 [v3]
Yumin Qi
minqi at openjdk.java.net
Thu Nov 12 05:46:55 UTC 2020
On Thu, 12 Nov 2020 05:25:26 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Please don't use the metaspace tag for logging inside these generic functions, this makes no sense. Also, I kept the "metaspace" log clean and consistent with JEP387. This should log with only "os" and nothing else.
>
> Contrary to David I think the original "info" level is fine. We have no guidelines for this unfortunately, but I usually do hard errors - which are too "soft" for warning level, which is printed always - at info. And this output will not be seen often.
>
> About UL circularity, UL should get fixed - it should not allocate memory while logging.
OK, I will use 'os' at info level then.
I will file a separate issue for UL heap allocation issue.
Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1150
More information about the hotspot-runtime-dev
mailing list