RFR: JDK-8256367: [windows] Better logging for some system calls

Thomas Stuefe stuefe at openjdk.java.net
Sat Nov 14 06:19:59 UTC 2020


Hi,

may I please have reviews for the following patch. Its purpose is to make error analysis easier for cases like https://bugs.openjdk.java.net/browse/JDK-8255917 or https://bugs.openjdk.java.net/browse/JDK-8255954.

It does two things:
- it adds consistent tracing to some of the more important system calls, especially those having to do with virtual memory handling. We now log the success case (on the highest level only) as well as the error case (on the lowest possible level below warning).
- It adds error handling and logging to os::split_reserved_memory(). It adds an assert if that function fails, since if it fails, we really should stop.

Thank you,

Thomas

-------------

Commit messages:
 - Initial

Changes: https://git.openjdk.java.net/jdk/pull/1214/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1214&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8256367
  Stats: 112 lines in 1 file changed: 91 ins; 5 del; 16 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1214.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1214/head:pull/1214

PR: https://git.openjdk.java.net/jdk/pull/1214


More information about the hotspot-runtime-dev mailing list