RFR: JDK-8256287: [windows] add loop fuse to map_or_reserve_memory_aligned [v2]

Thomas Stuefe stuefe at openjdk.java.net
Mon Nov 16 15:02:10 UTC 2020


On Mon, 16 Nov 2020 13:48:40 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove blank before unary ++
>>  - feedback alexey
>
> I'm not a reviewer but it looks good to me.

Hi Ludovic,

thanks a lot for looking at this! Reformed the loop as suggested.

> I'm not a reviewer but it looks good to me.

Your feedback is still useful. In the case of hotspot, the project rules want two reviews, only one of which has to be a Reviewer. 

I see that in the JDK project you are "just" an Author, but you are overdue for Committer anyway I think since you have ~11 patches authored or co-authored.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/1191


More information about the hotspot-runtime-dev mailing list