RFR: 8256383: PlatformMutex::try_lock has different semantics on Windows and Posix

Stefan Karlsson stefank at openjdk.java.net
Tue Nov 17 10:14:05 UTC 2020


On Tue, 17 Nov 2020 07:26:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Mutex::try_lock has to allow for the possibility that the PlatformMutex::try_lock allows recursive locking.
>> 
>> Added additional commentary on the semantics provided by Mutex and the PlatformMutex classes.
>> 
>> Testing: GHA, mach5 tiers 1-3
>
> Hi David,
> 
> LGTM. Minor remarks below.
> 
> Thanks, Thomas

> Using Atomic::load is a good idea just from a code hygiene perspective,
> but doesn't change the raciness.

My point was that because this is a racy read we _should_ use Atomic::load.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1247


More information about the hotspot-runtime-dev mailing list