RFR: 8134630: make code and comments consistent for stack lock optimization

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Nov 18 00:02:02 UTC 2020


On Tue, 17 Nov 2020 23:50:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Comment only changes copied from the 'arm' version to the aarch64 and x86
>> versions of the files. I looked at the ppc and s390 files and it wasn't at all clear
>> to me how to apply the same comment changes to those platforms.
>
> This looks good.  Sorry for the delay.  I was a bit unhappy with the same big comment in three places but nobody ever looks at all the places at once, so it's useful in all places.

@coleenp - Thanks for the review. Someday maybe an enterprising
soul will merge the 'arm' and 'aarch64' platforms, so we would have
one fewer place, but then the complaints will shift to all the #ifdefs... :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1210


More information about the hotspot-runtime-dev mailing list