RFR: 8255678: Add Mutex::try_lock version without rank checks [v2]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Wed Nov 18 00:39:23 UTC 2020


On Tue, 17 Nov 2020 23:52:55 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> Your call on whether to fix the nits. I like the new test!
> Most of the longer stress test runs happen in Tier7 and
> Tier8 so you should also run those.
Sounds good, I'll give it a run on tiers 7 and 8 then. 
Thanks for reviewing this Dan!

Patricio

> src/hotspot/share/runtime/mutex.cpp line 421:
> 
>> 419:       thread->print_owned_locks();
>> 420:       assert(false, "Attempting to acquire lock %s/%d out of order with lock %s/%d -- "
>> 421:              "possible deadlock", this->name(), this->rank(),least->name(), least->rank());
> 
> nit - missing blank - s/this->rank(),/this->rank(), /

Fixed.

> src/hotspot/share/runtime/mutex.hpp line 91:
> 
>> 89:   Mutex*  _next;                 // Used by a Thread to link up owned locks
>> 90:   Thread* _last_owner;           // the last thread to own the lock
>> 91:   bool _skip_rank_check;         // read only by owner whend doing rank checks
> 
> nit - typo: s/whend/when/

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1242


More information about the hotspot-runtime-dev mailing list