PING: RFR: 8256178: Add RAII object for file lock

Yasumasa Suenaga suenaga at oss.nttdata.com
Thu Nov 19 00:26:34 UTC 2020


PING: Could you review it?

> PR: https://git.openjdk.java.net/jdk/pull/1156

Yasumasa


On 2020/11/11 16:17, Yasumasa Suenaga wrote:
> This PR is subtask of [JDK-8256008](https://bugs.openjdk.java.net/browse/JDK-8256008) (#1106)
> 
> `LogFileStreamOutput::write()` uses `os::flockfile()` and `os::funlockfile()` to serialize write ops. It is better to use RAII because we can ensure `os::funlockfile()` call.
> 
> -------------
> 
> Commit messages:
>   - Add RAII object for file lock
> 
> Changes: https://git.openjdk.java.net/jdk/pull/1156/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1156&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8256178
>    Stats: 17 lines in 1 file changed: 14 ins; 0 del; 3 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/1156.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/1156/head:pull/1156
> 
> PR: https://git.openjdk.java.net/jdk/pull/1156
> 


More information about the hotspot-runtime-dev mailing list