RFR: 8255678: Add Mutex::try_lock version without rank checks [v4]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Thu Nov 19 03:40:08 UTC 2020


On Thu, 19 Nov 2020 03:24:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix whitespace
>
> test/hotspot/gtest/runtime/test_mutex_rank.cpp line 88:
> 
>> 86:   mutex_rankA_plus_one->unlock();
>> 87:   mutex_rankA->unlock();
>> 88:   mutex_rankA_plus_two->unlock();
> 
> I think you should add a test that _skip_rank_check is reset, ie. lock mutex_rankA_plus_one with plain try_lock and make sure it tests the rank.

Sounds good, I'll add that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1242


More information about the hotspot-runtime-dev mailing list