RFR: 8256618: Zero: Linux x86_32 build still fails [v2]

Andrew Haley aph at openjdk.java.net
Thu Nov 19 16:50:05 UTC 2020


On Thu, 19 Nov 2020 14:57:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> There is no os::workaround_expand_exec_shield_cs_limit symbol available:
>> 
>> 
>> collect2: error: ld returned 1 exit status
>> 
>> That symbol is defined in `os_linux_x86.cpp`, which is not available to Zero that builds `os_linux_zero.cpp`.
>> [JDK-8248271](https://bugs.openjdk.java.net/browse/JDK-8248271) added the declaration to `os_linux_zero.hpp`, but that is not enough, because the definition is still missing. I propose we move the definition up the hierarchy, to `os_linux.cpp` and protect it firmly with `IA32`.
>> 
>> Additional testing:
>>  - [x] Linux {x86_32, x86_64} server builds
>>  - [x] Linux {x86_32, x86_64} zero builds
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Touchups after merge
>  - Merge branch 'master' into JDK-8256618-zero-x86
>  - 8256618: Zero: Linux x86_32 build still fails

Marked as reviewed by aph (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1310


More information about the hotspot-runtime-dev mailing list