RFR: 8256594: Unexpected warning: SIGSEGV handler flags expected:SA_RESTART|SA_SIGINFO found:SA_RESTART|SA_SIGINFO [v2]

[David Holmes]

On Thu, 19 Nov 2020 21:58:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> LGTM.
>> 
>> Note that a maybe more elegant approach - avoiding the double definition of known flags - would have been, in the print loop, to store the checked flags in a mask. And then test for ~mask at the final step.
>> 
>> The numeric comparison of flags in check_jni - which requires this SA_RESTORER_FLAG_MASK workaround - is a bit grating. Would have been better to compare just known flags. But this is old coding.
>> 
>> All idle nitpicking :) Patch is fine.
>> 
>> ..Thomas
>
> Can I get a second review ASAP please as this is causing quite a bit of noise in the testing.
> Thanks.

When discussing with Coleen I realized I had omitted part of the fix -  the masking of VMError::get_resetted_sigflags(sig).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1309