RFR: 8256594: Unexpected warning: SIGSEGV handler flags expected:SA_RESTART|SA_SIGINFO found:SA_RESTART|SA_SIGINFO [v2]

[David Holmes]

On Fri, 20 Nov 2020 03:55:42 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added missing mask of VMError::get_resetted_sigflags(sig)
>
> Changes match what you described. Thumbs up.

Thanks for the reviews.

> src/hotspot/os/posix/signals_posix.cpp line 54:
> 
>> 52: // in this flag and need to ignore it when checking our
>> 53: // own flag settings.
>> 54: // Note: SA_RESTORER is not exposed through signal.h so we
> 
> Should this comment mention `SA_RESTORER` or `SA_RESTORER_FLAG_MASK`?

I'll tweak the comment before pushing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1309