RFR: 8256485: Zero VM build broken after JDK-8254231 [v2]

[Jorn Vernee]

On Mon, 23 Nov 2020 13:11:33 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/hotspot/cpu/zero/methodHandles_zero.cpp line 211:
>> 
>>> 209:   case vmIntrinsics::_invokeGeneric:
>>> 210:   case vmIntrinsics::_compiledLambdaForm:
>>> 211:   case vmIntrinsics::_linkToNative:
>> 
>> Sorry, another issue. What is this? Do we need this to compile Zero? Does it even make sense to have it for `method_handle_entry`?
>
> This function gets called during the build. If the case for linkToNative is not added it falls through to ShouldNotReachHere() in the default case.
> 
> Pointing it to method_handle_entry_invalid seemed like the best way to fix it, since the interpreter entry never gets used any ways. See method.cpp:
> 
>   if (iid == vmIntrinsics::_linkToNative) {
>     m->set_interpreter_entry(m->adapter()->get_i2c_entry());
>   }

(Though, I suppose in general the entry never gets used because we don't have a CLinker implementation for Zero)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1265