RFR: 8256675: Zero: purge biased locking support [v2]
Patricio Chilano Mateo
pchilanomate at openjdk.java.net
Mon Nov 23 19:13:58 UTC 2020
On Thu, 19 Nov 2020 19:55:34 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove more has_bias_pattern checks
>
> Hi Aleksey,
>
> Changes look good to me.
> There are 3 places left when unlocking the monitor where there is a has_bias_pattern() check. Maybe change them into an assert? (seems Github doesn't allow to add comments on collapsed lines).
>
> Thanks,
> Patricio
> That another commit that removes all `has_bias_pattern()`-s looks fine to you, @pchilano?
Yes, looks good. (Not sure why I thought you already pushed).
My suggestion was actually to assert that at monitorexit the markword cannot be biased, but still good.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1322
More information about the hotspot-runtime-dev
mailing list