RFR: 8256722: handle VC++:1927 VS2019 in abstract_vm_version
Fairoz Matte
fmatte at openjdk.java.net
Tue Nov 24 04:04:56 UTC 2020
On Tue, 24 Nov 2020 02:05:49 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> The C++ compiler handling coding in abstract_vm_version.cpp currently misses handling nicely for VC++:1927 VS2019.
>> Source:
>> https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B
>
> Looks good - and trivial IMO.
>
> As usual with these updates I lament the need for them in the first place - if only MSVC++ exported a version string directly.
>
> Thanks,
> David
Thanks Aleksey and David for the reviews.
I have executed basic testing and runtime/cds and didn't find any issues.
Thanks,
Fairoz
-------------
PR: https://git.openjdk.java.net/jdk/pull/1377
More information about the hotspot-runtime-dev
mailing list