RFR: 8256489: Make gtest for long path names on Windows more resilient in the presence of virus scanners [v2]

Ralf Schmelter rschmelter at openjdk.java.net
Tue Nov 24 09:36:02 UTC 2020


On Tue, 24 Nov 2020 01:20:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ralf Schmelter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Incorporated review findings from David Holmes
>>  - Make directory removal in path test more resilient
>
> test/hotspot/gtest/runtime/test_os_windows.cpp line 138:
> 
>> 136:   WITH_ABS_PATH(path);
>> 137:   EXPECT_TRUE(file_exists_w(abs_path)) << "Can't delete directory: \"" << path << "\" does not exists";
>> 138:   const int max_wait_time = 20;
> 
> This isn't a "wait time" it is a retry count.

Right, I've changed it to retry_count.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1380


More information about the hotspot-runtime-dev mailing list