RFR: 8256618: Zero: Linux x86_32 build still fails [v5]
David Holmes
dholmes at openjdk.java.net
Tue Nov 24 12:10:59 UTC 2020
On Tue, 24 Nov 2020 08:54:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> There is no os::workaround_expand_exec_shield_cs_limit symbol available:
>>
>>
>> collect2: error: ld returned 1 exit status
>>
>> That symbol is defined in `os_linux_x86.cpp`, which is not available to Zero that builds `os_linux_zero.cpp`.
>> [JDK-8248271](https://bugs.openjdk.java.net/browse/JDK-8248271) added the declaration to `os_linux_zero.hpp`, but that is not enough, because the definition is still missing. I propose we move the definition up the hierarchy, to `os_linux.cpp` and protect it firmly with `IA32`.
>>
>> Additional testing:
>> - [x] Linux {x86_32, x86_64} server builds
>> - [x] Linux {x86_32, x86_64} zero builds
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>
> - Just disable the workaround for Zero
> - Merge branch 'master' into JDK-8256618-zero-x86
> - Put the #ifdef to protect the comment too
> - Merge branch 'master' into JDK-8256618-zero-x86
> - Touchups after merge
> - Merge branch 'master' into JDK-8256618-zero-x86
> - 8256618: Zero: Linux x86_32 build still fails
Marked as reviewed by dholmes (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/1310
More information about the hotspot-runtime-dev
mailing list