RFR: 8256726: Zero: print proper message in ArrayIndexOutOfBoundException [v3]

Severin Gehwolf sgehwolf at openjdk.java.net
Fri Nov 27 09:30:10 UTC 2020


On Fri, 27 Nov 2020 09:27:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Manifests on tier1 test:
>> 
>> $ CONF=linux-x86_64-zero-fastdebug make run-test TEST=runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/
>> test ArrayIndexOutOfBoundsExceptionTest.testAIOOBMessages(): failure
>> java.lang.AssertionError: expected [Index -5 out of bounds for length 0] but found [-5]
>> 
>> Fix does similar thing to what `Runtime1::throw_range_check_exception` does, but using a safer `jio_snprintf`.
>> 
>> Additional testing:
>>  - [x] AIOBB tests on Linux x86_64 Zero fastdebug
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Even cleaner, with comments

Looks good. Thanks for the clean-up.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1341


More information about the hotspot-runtime-dev mailing list