RFR: 8257238: Cleanup include directives for precompiled.hpp

David Holmes dholmes at openjdk.java.net
Mon Nov 30 03:40:54 UTC 2020


On Mon, 30 Nov 2020 03:32:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> The precompiled header file is:
>> 
>> src/hotspot/share/precompiled/precompiled.hpp
>> 
>> The normal way to include precompiled headers is to just have:
>> 
>> #include "precompiled.hpp"
>> 
>> as the first directive in a file. This works because the makefiles set:
>> 
>>  -I$(TOPDIR)/src/hotspot/share/precompiled
>> 
>>  Some files instead have:
>> 
>> #include "precompiled/precompiled.hpp"
>> 
>> ./os/bsd/semaphore_bsd.cpp
>> ./os/linux/waitBarrier_linux.cpp
>> ./os/posix/semaphore_posix.cpp
>> ./os/posix/signals_posix.cpp
>> 
>> This should be trivially cleaned up.
>
> Looks good, and trivial.

Thanks Kim!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1510


More information about the hotspot-runtime-dev mailing list