RFR: 8257420: Zero VM build broken with clang after JDK-8256726 due to strlen() is not a constexpr [v2]

Jie Fu jiefu at openjdk.java.net
Mon Nov 30 15:04:10 UTC 2020


> Hi all,
> 
> The newly added STATIC_ASSERT [1] breaks the build of Zero VM with clang.
> It complains that 'non-type template argument is not a constant expression' since strlen() [2] is not a constexpr.
> 
> Any comments?
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp#L1374
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/flags/jvmFlagLookup.hpp#L42

Jie Fu has updated the pull request incrementally with two additional commits since the last revision:

 - Remove STATIC_ASSERT
 - Revert changes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1518/files
  - new: https://git.openjdk.java.net/jdk/pull/1518/files/72fa6987..0e948e54

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1518&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1518&range=00-01

  Stats: 22 lines in 3 files changed: 10 ins; 12 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1518.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1518/head:pull/1518

PR: https://git.openjdk.java.net/jdk/pull/1518


More information about the hotspot-runtime-dev mailing list