RFR: 8252324: Signal related code should be shared among POSIX platforms [v5]

[David Holmes]

On Thu, 1 Oct 2020 18:14:24 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> @gerard-ziemski Please do not force-push any commits in an open PR as it breaks the commit history and the chain of
>> review comments. I will not be able to see the merge issues actually fixed as a diff from the previous commit.
>
>> merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your
>> intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of
>> this pull request to `Merge <project>:<branch>` where `<project>` is the name of another project in the [OpenJDK
>> organization](https://github.com/openjdk) (for example `Merge jdk:master`).
> 
> Can anyone explain what this means and whether it's OK to go ahead with this pr, or should I close this one (since I
> made quite a mess of it) and start a new one?

Hi Gerard,

I'm afraid something is still very wrong here. I see you fixing the original merge issues in:

b33d292e96a559b8a3a998641411f61bf087738f  (Address David's review issues )

but then the "Fix Merge" commit

4f5d4cd49436b64dc3770e4ba1f811a76b5a09e7

applied after that seems to have reversed them again!

I think it might be necessary to close this PR and create a new one.

Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/157