RFR: 8252324: Signal related code should be shared among POSIX platforms [v5]
Thomas Stüfe
thomas.stuefe at gmail.com
Fri Oct 2 04:44:50 UTC 2020
>
> > Can anyone explain what this means and whether it's OK to go ahead with
> this pr, or should I close this one (since I
> > made quite a mess of it) and start a new one?
>
> Hi Gerard,
>
> I'm afraid something is still very wrong here. I see you fixing the
> original merge issues in:
>
> b33d292e96a559b8a3a998641411f61bf087738f (Address David's review issues )
>
> but then the "Fix Merge" commit
>
> 4f5d4cd49436b64dc3770e4ba1f811a76b5a09e7
>
> applied after that seems to have reversed them again!
>
> I think it might be necessary to close this PR and create a new one.
>
>
I agree. Also, then you get the new Activity-based builds and tier0 tests
for free since that submit.yml file is now checked in head :)
Cheers, Thomas
Thanks.
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/157
>
More information about the hotspot-runtime-dev
mailing list