RFR: 8253913: unify gtest test names [v2]

Stefan Karlsson stefank at openjdk.java.net
Fri Oct 2 06:25:05 UTC 2020


On Thu, 1 Oct 2020 22:16:16 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this small and trivial patch that unifies the names of hotspot gtests? in some cases, "_test"
>> is added to gtest names, in others it isn't. given some tests specify "test" in their names, so we get "test_test" like
>> in `UninitializedDoubleElementWorkerDataArrayTest.sum_test_test_vm`. the patch removes `_test` from the suffixes added
>> by `TEST*` macros.  testing: ✅ `make test TEST=gtest` on macosx-x64
>> ✅ `test/hotspot/jtreg/gtest/` on {linux,windows,macosx}-x64
>
> Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust test class names in LogStream's friends

Looks good. I think it's great that you clean this up. I started doing something similar myself, but never got around
to create an RFE for it. IIRC, when I looked at it there were more inconsistencies with the names, but maybe they are
gone now.

-------------

Marked as reviewed by stefank (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/475


More information about the hotspot-runtime-dev mailing list