RFR: 8253794: TestAbortVMOnSafepointTimeout never timeouts

Robbin Ehn rehn at openjdk.java.net
Fri Oct 2 07:18:08 UTC 2020


On Thu, 1 Oct 2020 20:11:12 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java line 49:
>> 
>>> 47:             System.out.println("This message would occur after some time.");
>>> 48:         } else {
>>> 49:             testWith(50, 1, 999);
>> 
>> Please consider:
>> 
>> `testWith(50 /* sfpt_interval */, 1 /* timeout_delay */, 999 /* unsafe_wait */);`
>
> Also, I think the test would be more clear if this testWith() part
> was in a `if (args.length == 0)` block at the top and the else
> part was the rest of the test. After all, code flow wise, you
> execute the `(args.length == 0)` case first and then come
> back for the case with the unsafe_wait value.

I only removed the return in favor of the else, the rest is the same as before.

-------------

PR: https://git.openjdk.java.net/jdk/pull/465


More information about the hotspot-runtime-dev mailing list