RFR: 8252324: Signal related code should be shared among POSIX platforms [v5]

[Gerard Ziemski]

On Fri, 2 Oct 2020 16:23:14 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Hi Gerard,
>> 
>> I'm afraid something is still very wrong here. I see you fixing the original merge issues in:
>> 
>> b33d292e96a559b8a3a998641411f61bf087738f  (Address David's review issues )
>> 
>> but then the "Fix Merge" commit
>> 
>> 4f5d4cd49436b64dc3770e4ba1f811a76b5a09e7
>> 
>> applied after that seems to have reversed them again!
>> 
>> I think it might be necessary to close this PR and create a new one.
>> 
>> Thanks.
>
> I'm considering this pr to be "lost cause", so I just "force pushed" to a known good state, wiping out the bad merge
> that backed out my fixes based on David's comments, so that I have a snapshot of what I want to become the basis of new
> pr.  Just thought I would explain what I'm trying to do before anyone points out to me that I should not be using
> "push --force".

> _Mailing list message from [Thomas St��fe](mailto:thomas.stuefe at gmail.com) on
> [hotspot-runtime-dev](mailto:hotspot-runtime-dev at openjdk.java.net):_
> > > Can anyone explain what this means and whether it's OK to go ahead with
> > > this pr, or should I close this one (since I
> > > made quite a mess of it) and start a new one?
> > 
> > 
> > Hi Gerard,
> > I'm afraid something is still very wrong here. I see you fixing the
> > original merge issues in:
> > [b33d292](https://github.com/openjdk/jdk/commit/b33d292e96a559b8a3a998641411f61bf087738f)  (Address David's review
> > issues ) but then the "Fix Merge" commit
> > [4f5d4cd](https://github.com/openjdk/jdk/commit/4f5d4cd49436b64dc3770e4ba1f811a76b5a09e7)
> > applied after that seems to have reversed them again!
> > I think it might be necessary to close this PR and create a new one.
> 
> I agree. Also, then you get the new Activity-based builds and tier0 tests
> for free since that submit.yml file is now checked in head :)
> 
> Cheers, Thomas
> 
> Thanks.

I think I recovered this pr to the point where we could continue with reviews (all changes are in and it passes Mach5
hs-tier1,2,3,4,5 testing), but I do like the idea of Activity-based builds and tier0 tests with new pr, so I'm going to
close this one, and open a new one shortly...

Thank you Thomas and David for assuring me that the huge merges eventually get resolved and disappear
automatically -that was the reason I started tweaking this pr and why I got it messed up.

-------------

PR: https://git.openjdk.java.net/jdk/pull/157