RFR: 8252324: Signal related code should be shared among POSIX platforms

Thomas Stüfe thomas.stuefe at gmail.com
Mon Oct 5 12:30:29 UTC 2020


On Mon, Oct 5, 2020 at 2:26 PM Thomas Stuefe <stuefe at openjdk.java.net>
wrote:

> On Sat, 3 Oct 2020 17:12:30 GMT, Gerard Ziemski <gziemski at openjdk.org>
> wrote:
>
> > This is a fresh start for https://github.com/openjdk/jdk/pull/157
> >
> > Please review this change that refactors common POSIX code into a
> separate
> > file.
> >
> > Currently there appears to be quite a bit of duplicated code among POSIX
> > platforms, which makes it difficult to apply single fix to the signal
> code.
> > With this fix, we will only need to touch single file for common POSIX
> > code fixes from now on.
> >
> > ---------
> > ### Progress
> > - [x] Change must not contain extraneous whitespace
> > - [x] Commit message must refer to an issue
> > - [ ] Change must be properly reviewed
> >
> >
> >
> > ### Download
> > `$ git fetch https://git.openjdk.java.net/jdk pull/497/head:pull/497`
> > `$ git checkout pull/497`
>
> I put the new patch into our test queue to give it another spin. Will take
> a last look next week.
>
>
I wrote this comment yesterday evening, the GitHub ML bot seems to be
rather slow.
Yesterday was Sunday, so I mean this week.

-------------
>
> PR: https://git.openjdk.java.net/jdk/pull/497
>


More information about the hotspot-runtime-dev mailing list