RFR: 8253794: TestAbortVMOnSafepointTimeout never timeouts [v2]
Daniel D.Daugherty
dcubed at openjdk.java.net
Mon Oct 5 15:47:49 UTC 2020
On Mon, 5 Oct 2020 15:33:01 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update with input from reviews
>
> Changes requested by dcubed (Reviewer).
Robbin replied:
> David H. wrote:
> > That all said, for the record, we really should have a handshake timeout mechanism the same as we have the safepoint
> > timeout mechanism.
>
> We have a timeout mechanism but default off HandshakeTimeout.
> But it doesn't fire SIGILL to troubled thread as safepoint does.
What's the conclusion here? Are there going to be changes to the
test to use the HandshakeTimeout option? Should the test have
failed in a different way than it did?
-------------
PR: https://git.openjdk.java.net/jdk/pull/465
More information about the hotspot-runtime-dev
mailing list