RFR: 8253794: TestAbortVMOnSafepointTimeout never timeouts [v2]
Robbin Ehn
rehn at openjdk.java.net
Mon Oct 5 18:24:47 UTC 2020
On Mon, 5 Oct 2020 15:31:01 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> The line "This message would occur after some time." should never be print if VM is working.
>> If the VM fails for some reason and the timeout is not performed, line:
>> "Timed out while spinning to reach a safepoint." is never printed and the OutputAnalyzer fails the test.
>> If we did timeout and it was printed we know that we didn't print the other message, since the only thread that can
>> timeout is the one printing that message.
>> The second part verifies that the SIGILL was delivered.
>
> Okay, but then this message when you're reading the code is misleading:
> `System.out.println("This message would occur after some time.");`
> It should be printing something like:
> `System.out.println("This message only prints if something is broken.");`
>
> Update: Yes, I realize that this is an existing problem, but it's still reads wrong.
I removed comment in last update, since it can't be printed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/465
More information about the hotspot-runtime-dev
mailing list