RFR: 8252324: Signal related code should be shared among POSIX platforms

Yasumasa Suenaga ysuenaga at openjdk.java.net
Tue Oct 6 09:30:43 UTC 2020


On Tue, 6 Oct 2020 05:52:51 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This is a fresh start for https://github.com/openjdk/jdk/pull/157
>> 
>> Please review this change that refactors common POSIX code into a separate
>> file.
>> 
>> Currently there appears to be quite a bit of duplicated code among POSIX
>> platforms, which makes it difficult to apply single fix to the signal code.
>> With this fix, we will only need to touch single file for common POSIX
>> code fixes from now on.
>> 
>> ---------
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>> - [ ] Change must be properly reviewed
>> 
>> 
>> 
>> ### Download
>> `$ git fetch https://git.openjdk.java.net/jdk pull/497/head:pull/497`
>> `$ git checkout pull/497`
>
> src/hotspot/os/posix/signals_posix.cpp line 454:
> 
>> 452:                                                void* ucontext,
>> 453:                                                int abort_if_unrecognized);
>> 454: #endif
> 
> Future cleanup: I think it will be difficult to unify the platform specific signal handlers (but worthwhile). But the
> naming could be at least the same, no reason to have the platform in the name.

I agree with @tstuefe . Can we rename them to `JVM_handle_posix_signal` ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/497


More information about the hotspot-runtime-dev mailing list