RFR: 8252324: Signal related code should be shared among POSIX platforms

[Gerard Ziemski]

On Tue, 6 Oct 2020 05:43:49 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This is a fresh start for https://github.com/openjdk/jdk/pull/157
>> 
>> Please review this change that refactors common POSIX code into a separate
>> file.
>> 
>> Currently there appears to be quite a bit of duplicated code among POSIX
>> platforms, which makes it difficult to apply single fix to the signal code.
>> With this fix, we will only need to touch single file for common POSIX
>> code fixes from now on.
>> 
>> ---------
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>> - [ ] Change must be properly reviewed
>> 
>> 
>> 
>> ### Download
>> `$ git fetch https://git.openjdk.java.net/jdk pull/497/head:pull/497`
>> `$ git checkout pull/497`
>
> src/hotspot/os/bsd/os_bsd.cpp line 2285:
> 
>> 2283:
>> 2284: void os::SuspendedThreadTask::internal_do_task() {
>> 2285:   if (PosixSignals::do_suspend(_thread->osthread())) {
> 
> Future RFE: os::SuspendedThreadTask::internal_do_task() can be unified across posix platforms.

Will be addressed in https://bugs.openjdk.java.net/browse/JDK-8253742

> src/hotspot/os/bsd/os_bsd.cpp line 2152:
> 
>> 2150:   if (!ReduceSignalUsage) {
>> 2151:     PosixSignals::jdk_misc_signal_init();
>> 2152:   }
> 
> This whole section could be unified too into an own PosixSignals::initial_signal_stuff() function. Potentially for a
> future RFE.

Will be addressed in https://bugs.openjdk.java.net/browse/JDK-8253742

-------------

PR: https://git.openjdk.java.net/jdk/pull/497