RFR: 8253833: mutexLocker assert_locked_or_safepoint should not access VMThread state from non-VM-thread

Robbin Ehn rehn at openjdk.java.net
Fri Oct 9 16:00:14 UTC 2020


On Fri, 9 Oct 2020 14:27:07 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> > > But an entire over-haul of these asserts and what the implicit rules are is out of scope here.
> > 
> > 
> > Yes and I think if we can't formulate the exact condition then logically
> > we have:
> > (is_at_safepoint() && is_VMThread()) || (is_at_safepoint() &&
> > complexConditionWeHaveToAssumeIsTrue())
> > which simplifies to just
> > is_at_safepoint()
> > :)
> 
> I love `complexConditionWeHaveToAssumeIsTrue()`!!
> Ahhhhh... thanks for giving me a reason to smile on Friday morning!!

:)

-------------

PR: https://git.openjdk.java.net/jdk/pull/563


More information about the hotspot-runtime-dev mailing list