Integrated: 8253833: mutexLocker assert_locked_or_safepoint should not access VMThread state from non-VM-thread

Robbin Ehn rehn at openjdk.java.net
Mon Oct 12 06:06:11 UTC 2020


On Thu, 8 Oct 2020 13:08:51 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> It's unsafe for all threads except VM thread to access the current vm operation.
> This part of the assert is also faulty:
> If we are not at safepoint and the operation requester (calling thread) would be the owner of the lock do not mean it
> is safe for current thread.
> Passes t1-5. (also note VMThread::vm_operation() assert current thread is VM thread, and I have seen no such assert)
> 
> Thanks

This pull request has now been integrated.

Changeset: 45b09a3f
Author:    Robbin Ehn <rehn at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/45b09a3f
Stats:     3 lines in 1 file changed: 0 ins; 3 del; 0 mod

8253833: mutexLocker assert_locked_or_safepoint should not access VMThread state from non-VM-thread

Reviewed-by: shade, coleenp, dcubed, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/563


More information about the hotspot-runtime-dev mailing list