RFR: 8254586: Replace fthrow() calls with simpler method calls in classFileParser.cpp

Coleen Phillimore coleenp at openjdk.java.net
Mon Oct 12 22:22:17 UTC 2020


On Mon, 12 Oct 2020 21:44:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi,
>> Please review this small change to simplify exception throwing in classFileParser.cpp  The change was tested with tiers
>> one and two on Windows, Linux x64, and Mac OSX, and with tiers 3-5 on Linux x64.
>> Thanks, Harold
>
> src/hotspot/share/classfile/classFileError.cpp line 81:
> 
>> 79: }
>> 80:
>> 81: void ClassFileParser::classfile_icce_error(const char* msg,
> 
> Is there a reason we can't just use THROW_MSG at the callsites rather than introducing these helper functions?

I think it's intended to match existing usage.

-------------

PR: https://git.openjdk.java.net/jdk/pull/618


More information about the hotspot-runtime-dev mailing list