RFR: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid) [v2]

Jie Fu jiefu at openjdk.java.net
Tue Oct 13 13:27:36 UTC 2020


> __sync_val_compare_and_swap shouldn't call with narrowOop* for clang after JDK-8247912.
> Before passing type T to __sync_val_compare_and_swap, the fix converts T to uint32_t* if sizeof(T) == 4.
> 
> Testing:
>  - Zero VM build on Linux and MacOS with clang
>  - Zero VM build on Linux with gcc

Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes
the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last
revision:

 - Replace __sync_val_compare_and_swap whith __atomic_compare_exchange
 - Merge branch 'master' into JDK-8253970
 - Revert changes
 - 8253970 Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *'
   invalid)

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/496/files
  - new: https://git.openjdk.java.net/jdk/pull/496/files/52ba86d9..420ead76

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=496&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=496&range=00-01

  Stats: 32415 lines in 756 files changed: 19888 ins; 7845 del; 4682 mod
  Patch: https://git.openjdk.java.net/jdk/pull/496.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/496/head:pull/496

PR: https://git.openjdk.java.net/jdk/pull/496


More information about the hotspot-runtime-dev mailing list