RFR: 8254263: Remove special_runtime_exit_condition() check from ~ThreadInVMForHandshake() [v3]
Patricio Chilano Mateo
pchilanomate at openjdk.java.net
Tue Oct 13 21:45:26 UTC 2020
> Hi all,
>
> Please review the following patch that removes the call to handle_special_runtime_exit_condition() in
> ~ThreadInVMForHandshake(). This check was added by 8223572 to prevent a JavaThread that was suspended while trying to
> process a handshake to transition back to java without noticing it was suspended. Since 8238761, a JavaThread executing
> HandshakeState::process_by_self() will never become safe. It comes from an unsafe state and remains unsafe, so it
> cannot be suspended during that time. Removing this check also removes one of the reasons
> SafepointMechanism::process_if_requested() is recursive (the other one remains SafepointSynchronize::block()). Tested
> in mach5, tiers 1-7. Thanks, Patricio
Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
fix assert message
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/577/files
- new: https://git.openjdk.java.net/jdk/pull/577/files/d1222d98..7f81376d
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=577&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=577&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/577.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/577/head:pull/577
PR: https://git.openjdk.java.net/jdk/pull/577
More information about the hotspot-runtime-dev
mailing list