RFR: 8254012: NMT: MetaspaceSnapshot::snapshot uses wrong enum

Wed Oct 14 07:49:09 UTC 2020

On Tue, 13 Oct 2020 23:40:54 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Please review this simple change.
> Snapshot should be done first on NonClassType which will include ClassType allocation when
> Metaspace::using_class_space() is false.  _class_vsm (a VirtualSpaceManager) is set only for class type allocation when
> using_class_space is true. The correct order is do snapshot for NonClassType first, then for ClassType if
> using_class_space.  Tests: mach5 tier1-4 in progress.

The change looks good // not Reviewer though.
Thanks for fixing!

-------------

Marked as reviewed by rrich (Committer).

PR: https://git.openjdk.java.net/jdk/pull/645