RFR: JDK-8212218: [TESTBUG] runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryErrorInMetaspace.java timed out [v2]

[David Holmes]

Hi Thomas,

Unfortunately your change breaks our validation build as this update:

* Copyright (c) 2018, 2020 Oracle and/or its affiliates. All rights 
reserved.

is missing a comma after 2020. can you file a bug anf xi please.

Thanks,
David

On 14/10/2020 7:41 pm, Thomas Stuefe wrote:
>> Hi,
>>
>> this is a very simple test fix.
>>
>> TestHeapDumpOnOutOfMemoryErrorInMetaspace tests that Metaspace OOMs result in heap dumps if VM had been started
>> with -XX:+HeapDumpOnOutOfMemoryError.
>> The test fills Metaspace up to the limit (MaxMetaspaceSize) to provoke a Metaspace OOM. It sets MaxMetaspaceSize to 64m
>>
>> 64m gives us room for about ~62000 classes with the current VM. With JEP387, this becomes more like 68000 classes.
>>
>> 6x000 classes are a lot and if test runs on a debug VM they cause long verification times from compiler dependency
>> checks as well as CLDG verification. Both verifications behave quadratic. On our slow ppc machines this often leads to
>> timeouts (test takes about 22 minutes).  I lowered MaxMetaspaceSize to 16m which is fine for this test and reduces the
>> number of loaded classes to ~12000 classes resp 15000 with JEP387. This eases verification costs a lot.
>> I also switch off compiler dependency checks because a number of similar runtime tests do the same.
>>
>> I left it at that because that brings down test time on our ppc machine to ~30 seconds, which is fine.
> 
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>    Remove offending copyright line
> 
> -------------
> 
> Changes:
>    - all: https://git.openjdk.java.net/jdk/pull/637/files
>    - new: https://git.openjdk.java.net/jdk/pull/637/files/f380e698..02d094bf
> 
> Webrevs:
>   - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=637&range=01
>   - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=637&range=00-01
> 
>    Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/637.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/637/head:pull/637
> 
> PR: https://git.openjdk.java.net/jdk/pull/637
>