RFR: 8254799: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java fails with release VMs

[David Holmes]

On 15/10/2020 12:06 pm, Jie Fu wrote:
> On Thu, 15 Oct 2020 01:24:21 GMT, Jie Fu <jiefu at openjdk.org> wrote:
> 
>>> Changes requested by dcubed (Reviewer).
>>
>> I like @dholmes-ora 's solution and will update the PR soon.
>> Thanks.
> 
> Unfortunately, the following fix doesn't work.
> Platform.isDebugBuild() ? "-XX:-VerifyDependencies" : "",
> It seems that ProcessTools.createJavaProcessBuilder doesn't allow empty string as an arg.

Well that is annoying - not quite sure how that arises but anyway ...

> Would you mind something like:
> Platform.isDebugBuild() ? "-XX:-VerifyDependencies" : "-XX:MaxMetaspaceSize=16m",

Just use "-Dx" as the dummy argument.

Thanks,
David

> If you don't like it, I still prefer -XX:+IgnoreUnrecognizedVMOptions.
> I've grepped under jdk/test finding that there are about 700+ tests using -XX:+IgnoreUnrecognizedVMOptions.
> I didn't get the point why -XX:+IgnoreUnrecognizedVMOptions should be avoided for this case.
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/673
>