RFR: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid) [v3]

[Kim Barrett]

On Wed, 14 Oct 2020 12:52:35 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> __sync_val_compare_and_swap shouldn't call with narrowOop* for clang after JDK-8247912.
>> Before passing type T to __sync_val_compare_and_swap, the fix converts T to uint32_t* if sizeof(T) == 4.
>> 
>> Testing:
>>  - Zero VM build on Linux and MacOS with clang
>>  - Zero VM build on Linux with gcc
>
> Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes
> the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last
> revision:
>  - Merge branch 'master' into JDK-8253970
>  - Add FULL_MEM_BARRIER
>  - Merge branch 'master' into JDK-8253970
>  - Revert changes
>  - Replace __sync_val_compare_and_swap whith __atomic_compare_exchange
>  - Merge branch 'master' into JDK-8253970
>  - Revert changes
>  - 8253970 Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *'
>    invalid)

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/496