RFR: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid) [v3]

Kim Barrett kim.barrett at oracle.com
Thu Oct 15 15:56:33 UTC 2020


> On Oct 15, 2020, at 2:30 AM, Jie Fu <jiefu at openjdk.java.net> wrote:
> 
> On Thu, 15 Oct 2020 03:20:40 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> 
>>> Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes
>>> the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last
>>> revision:
>>> - Merge branch 'master' into JDK-8253970
>>> - Add FULL_MEM_BARRIER
>>> - Merge branch 'master' into JDK-8253970
>>> - Revert changes
>>> - Replace __sync_val_compare_and_swap whith __atomic_compare_exchange
>>> - Merge branch 'master' into JDK-8253970
>>> - Revert changes
>>> - 8253970 Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *'
>>>   invalid)
>> 
>> Looks good.
> 
> Thanks @kimbarrett for your review.
> Will push it tomorrow if there is no objection.

There should normally be a second reviewer for HotSpot changes.

> PR: https://git.openjdk.java.net/jdk/pull/496




More information about the hotspot-runtime-dev mailing list