RFR: 8254855: Clean up and remove unused code in vmIntrinsics

[David Holmes]

On 16/10/2020 9:28 am, Claes Redestad wrote:
> On Thu, 15 Oct 2020 23:03:07 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> I don't agree with removing F_RNY just because we don't currently have intrinisics that match that shape! If someone
>> were to add one then they would now have to repair the infrastructure code needed to support that.
> 
> Several potentially useful permutations of static, native and synchronized are already missing, so I felt that removing
> a no longer used variant to be in the spirit of the existing code. I think the infrastructure is easy to repair if it's
> ever needed (at least easier than the act of adding an intrinsics), but if you feel strongly about it I'll add it back.

The flags do not define a simple set of permutations - that is part of 
the problem I have with removing one. It is unclear when you actually 
need to signify native or synchronized. So I think it would be unclear 
as to when you might need to add this back, and how to actually add it back.

But I don't write intrinsics ... so why is this being reviewed by 
runtime rather the compiler folk who actually use this? :)

Cheers,
David
-----

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/688
>